Fix back-button history for turbo-frames #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robacarp
approved these changes
Feb 2, 2024
Good call, I'll start a new PR with tests. I want to add tests for a few of these stimulus things I've done recently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with turbo-frame elements where you can target them to be updated while preserving the overall page state, but the URL does not change to reflect this and the browse back button does not work. This may be intended behavior or it may be a bug with Turbo, I can't tell. I have an open issue with them here: hotwired/turbo#1156
But regardless, we want it to work because clicking a conversation in the left sidebar refreshes the turbo-frame id="conversation" in the right side. We do the frame refreshing because we want the scroll position of the left side to remain preserved.
This works by manually updating the browser's pushState and manually handling the back button for these cases. Demo here: https://share.zight.com/jku8YrZLj